Updated DesktopOsHelper.IsMac to work properly on net10 + macOS 26 #5541
+1
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@fengga - smth for you to review |
Author
|
Hey @bgavrilMS / @fengga , any chance of a review here 🙂 ? |
Author
|
This is still broken BTW, and net10 is GA now |
|
This is a real thing blocking me from updating a project to .NET 10. For what it's worth, here are some values from my machine: Log.Debug("Platform: {OsVersionPlatform}", Environment.OSVersion.Platform);
Log.Debug("OSDescription: {OsDescription}", RuntimeInformation.OSDescription);
Log.Debug("Is OSX: {IsOsPlatform}", RuntimeInformation.IsOSPlatform(OSPlatform.OSX));(so I think you could either look for the string "macOS" (as in this PR) or call For comparison, here are the values from .NET 9: Update: the problem isn't specific to MacOS 26! It also happens with .NET 10 on earlier OS versions: |
src/client/Microsoft.Identity.Client/PlatformsCommon/Shared/DesktopOsHelper.cs
Outdated
Show resolved
Hide resolved
DharshanBJ
approved these changes
Dec 4, 2025
bgavrilMS
approved these changes
Dec 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this request
Before .NET 10,
RuntimeInformation.OSDescriptioncalledunameon *nix systems to populate itself. Now it uses a nicer way using the .NET runtime target information, that means that field no longer containsDarwin, soIsMacalways returned false. This simply lets that method check formacOsas well.Testing
I couldn't find any unit tests for this class.
Performance impact
None